New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P1645R1 constexpr for <numeric> algorithms #3473
Conversation
... and please revert the order of the two lines in the commit comment: Paper number and title first; NB comment references in the body of the commit message. |
I did my best to follow the guiodelines at https://github.com/cplusplus/draft/wiki/Commit-message-format, which states that NB comments should start with "NB US 123 (C++14 CD):". If that is not correct, please fix the documentation and I will happily follow suit. I.e. I would like to know the correct representation before guessing again at what it should be. Some examples would help! Fwiw, I've seen your commit msgs for NB issues, and while I much prefer them, they do not follow our guidelines as I understand them. As for other changes, I assume none are necessary? So just the commit comment should be changed, right? That would require a force-push which we are not supposed to do (after the PR has been created), so @zygoloid will have to fix that when he merges the motion. Please correct me if I've misunderstood anything. |
@burblebee, please read the text on the quoted wiki page carefully:
This is not an editorial NB comment resolution, this is a P paper being applied (that also happens to fix one or more NB comments). |
Ah, I missed that. Thank you for pointing this out. That said, I would have to force push the branch to fix this. @zygoloid, do you want me to fix and force push or do you want to make these changes when you merge? Note that all of the NB papers I edited will need to be fixed. |
328ccfb
to
bae49c8
Compare
Also fixes NB US 320 (C++20 CD).
bae49c8
to
3272d2e
Compare
Fixes #3425.
Fixes cplusplus/nbballot#316
Fixes cplusplus/papers#432