Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P1645R1 constexpr for <numeric> algorithms #3473

Merged
merged 2 commits into from Nov 24, 2019
Merged

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Nov 16, 2019

@jensmaurer jensmaurer added this to the post-2019-11 milestone Nov 16, 2019
@jensmaurer jensmaurer changed the title Motions 2019 11 lwg 23: P1645R1 constexpr for <numeric> algorithms P1645R1 constexpr for <numeric> algorithms Nov 17, 2019
source/support.tex Show resolved Hide resolved
@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Nov 17, 2019
@jensmaurer
Copy link
Member

... and please revert the order of the two lines in the commit comment: Paper number and title first; NB comment references in the body of the commit message.

@burblebee
Copy link
Contributor Author

burblebee commented Nov 19, 2019

... and please revert the order of the two lines in the commit comment: Paper number and title first; NB comment references in the body of the commit message.

I did my best to follow the guiodelines at https://github.com/cplusplus/draft/wiki/Commit-message-format, which states that NB comments should start with "NB US 123 (C++14 CD):". If that is not correct, please fix the documentation and I will happily follow suit. I.e. I would like to know the correct representation before guessing again at what it should be. Some examples would help! Fwiw, I've seen your commit msgs for NB issues, and while I much prefer them, they do not follow our guidelines as I understand them.

As for other changes, I assume none are necessary? So just the commit comment should be changed, right? That would require a force-push which we are not supposed to do (after the PR has been created), so @zygoloid will have to fix that when he merges the motion. Please correct me if I've misunderstood anything.

@jensmaurer
Copy link
Member

jensmaurer commented Nov 19, 2019

@burblebee, please read the text on the quoted wiki page carefully:

For a commit that incorporates a N paper, P paper, LWG issue resolution, CWG issue resolution, or editorial NB comment resolution, commit messages for these take the form:

This is not an editorial NB comment resolution, this is a P paper being applied (that also happens to fix one or more NB comments).
So, please use "P1234R5 Title From Paper" and keep reading for the "Also fixes".

@burblebee
Copy link
Contributor Author

@jensmaurer

@burblebee, please read the text on the quoted wiki page carefully:

For a commit that incorporates a N paper, P paper, LWG issue resolution, CWG issue resolution, or editorial NB comment resolution, commit messages for these take the form: ...

Ah, I missed that. Thank you for pointing this out. That said, I would have to force push the branch to fix this. @zygoloid, do you want me to fix and force push or do you want to make these changes when you merge? Note that all of the NB papers I edited will need to be fixed.

@jensmaurer jensmaurer removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Nov 22, 2019
@zygoloid zygoloid merged commit 57d9e15 into master Nov 24, 2019
@jensmaurer jensmaurer deleted the motions-2019-11-lwg-23 branch February 18, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants