LWG Motion 19: P1902R1 Missing feature-test macros 2017-2019 #3476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohelEGP
suggested changes
Nov 16, 2019
cpplearner
reviewed
Nov 16, 2019
jensmaurer
added
the
changes requested
|
This also fixes GB 147. Please fix the commit comment accordingly. |
jensmaurer
requested changes
Nov 18, 2019
There was a problem hiding this comment.
Do not change the value of the "chrono" macro. See @brevzin's comment.
burblebee
pushed a commit
that referenced
this pull request
Nov 19, 2019
burblebee
removed
the
changes requested
jensmaurer
added
the
needs rebase
jensmaurer
approved these changes
Nov 22, 2019
zygoloid
removed
the
needs rebase
|
(We don't need the [needs rebase] label on motion pull requests; they get rebased as part of the merge process, and we want them to be based on the pre-motions master before that.) |
zygoloid
pushed a commit
that referenced
this pull request
Nov 23, 2019
zygoloid
force-pushed
the
motions-2019-11-lwg-19
branch
from
8cabcc6
to
28e87a0
Compare
added 2 commits
November 23, 2019 20:14
Fixes NB FI 15, GB 146, US 150, US 167, and DE 168 (C++20 CD), and LWG2334. Changes to macros in table 36 of [support.limits.general] were applied to the macro definitions in [version.syn].
zygoloid
force-pushed
the
motions-2019-11-lwg-19
branch
from
28e87a0
to
e6428e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NB FI 15, GB 146, US 150, US 167, and DE 168 (C++20 CD), and LWG2334.
Changes to macros in table 36 of [support.limits.general] were
applied to the macro definitions in [version.syn].
Fixes #3421.
Fixes cplusplus/nbballot#15
Fixes cplusplus/nbballot#145
Fixes cplusplus/nbballot#146
Fixes cplusplus/nbballot#149
Fixes cplusplus/nbballot#165
Fixes cplusplus/nbballot#166
Fixes cplusplus/papers#650