LWG Motion 18: P1960R0 NB Comment Changes Reviewed by SG1 #3477
+39
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need the paper number + title first (as-if this were a regular commit), and in the body: |
Ok, thanks for letting me know. Unless directed otherwise, I'll assume @zygoloid will take care of this when he merges. |
zygoloid
force-pushed
the
motions-2019-11-lwg-18
branch
from
433c830 to
e5363ac
Compare
zygoloid
approved these changes
Nov 23, 2019
Also fixes NB US 355, US 358, US 359, US 356, and US 364 (C++20 CD).
zygoloid
force-pushed
the
motions-2019-11-lwg-18
branch
from
e5363ac to
d7d681f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB US 355, US 358, US 359, US 356, US 364 (C++20 CD):
P1960R0 NB Comment Changes Reviewed by SG1
Fixes #3420.
Issues: Is the commit message correct? I did my best to follow our guidelines.
Fixes cplusplus/nbballot#351
Fixes cplusplus/nbballot#352
Fixes cplusplus/nbballot#354
Fixes cplusplus/nbballot#355
Fixes cplusplus/nbballot#359