New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Motions 2019 11 cwg 3: P1971R0 Core Language Changes for NB Comments #3481
Conversation
The comments use "constraint" with two different meanings:
This overloaded meaning for "constraint" is fairly common usage when discussing code, it's annoying to always clearly specify "atomic constraint expression" or "associated constraints" when the context generally makes it clear. Given that the point of examples in the Standard is to explain things to folks who don't know that the context makes the meaning clear and why, we should avoid overloading meanings like this. I suggest using " |
@CaseyCarter Thanks for your suggestions. So for US111, we now have this in [temp.constr.op] :
Which still doesn't quite read right to me. What do you think? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
… identity [namespace.udecl] Added commas to clarify that the phrases following the amended lists apply to all elements in the list.
…omatic storage duration
1e8f6d2
to
fbe7251
Compare
versus "does not disqualify some other expression from being a core constant expression".
…urn_value to be void
[dcl.fct.def.coroutine] Changed "/await-resume/" to "the /await-resume/ expression".
[module.private.frag] Changed "TU" to "translation unit" (TU is not specified).
the note, and update the example to match a revised version from Nathan Sidwell.
Referenced change to [module.global]/p9 applied to [module.import]/p9.
unclear in a note; instead merely clarify the language's response to the various options available to the programmer.
…ader units [cpp.import]/p3 Changed the wording "are encouraged not to treat them" to "are encouraged to not treat them".
fbe7251
to
af5d427
Compare
Fixes #3396.
Fixes cplusplus/nbballot#7.
Fixes cplusplus/nbballot#41.
Fixes cplusplus/nbballot#19.
Fixes cplusplus/nbballot#20.
Fixes cplusplus/nbballot#37.
Fixes cplusplus/nbballot#43.
Fixes cplusplus/nbballot#51.
Fixes cplusplus/nbballot#52.
Fixes cplusplus/nbballot#64.
Fixes cplusplus/nbballot#78.
Fixes cplusplus/nbballot#86.
Fixes cplusplus/nbballot#108.
Fixes cplusplus/nbballot#109.
Fixes cplusplus/nbballot#110.
Fixes cplusplus/nbballot#131.
Fixes cplusplus/nbballot#363.
Fixes cplusplus/nbballot#374.
Issues: