Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix names of std lib concepts with "std::" in the core clauses #3495

Closed
jensmaurer opened this issue Nov 19, 2019 · 3 comments · Fixed by #3860
Closed

Prefix names of std lib concepts with "std::" in the core clauses #3495

jensmaurer opened this issue Nov 19, 2019 · 3 comments · Fixed by #3860
Assignees
@jensmaurer

Comments

@jensmaurer
Copy link
Member

The core clauses mention library concepts in some examples.

It is our habit to prefix names from the standard library with std:: if they appear in the core language clauses, to highlight their provenance.

I'd like to have a nod that we'll be doing the same for concept names from the standard library.
@jensmaurer jensmaurer added the decision-required A decision of the editorial group (or the Project Editor) is required. label Nov 19, 2019
@zygoloid
Copy link
Member

Can you provide some examples?

@jensmaurer
Copy link
Member Author

jensmaurer commented Nov 20, 2019 •
edited

Good: [over.match.class.deduct] p6

template<std::integral W> using B = A<W>;

Bad: [expr.prim.req] p3

template<typename T>
   concept R = requires (T i) {
      typename T::type;
      {*i} -> convertible_to<const typename T::type&>;
   };

(Since this is an example in the definition of requires-expression, readers might be tricked into thinking that convertible_to is a built-in thing.)

@jensmaurer jensmaurer removed the decision-required A decision of the editorial group (or the Project Editor) is required. label Feb 10, 2020
@jensmaurer
Copy link
Member Author

Editorial meeting: Agreed, add std:: prefixes.

@jensmaurer jensmaurer self-assigned this Mar 10, 2020
@jensmaurer jensmaurer mentioned this issue Mar 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jensmaurer jensmaurer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[expr.prim.req,temp.concept] Add std:: qualification for library conc… jensmaurer/draft
2 participants
@zygoloid @jensmaurer