Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[localization] Change bold-slanted font, removes warning #350

Merged
merged 1 commit into from Dec 9, 2015

Conversation

tkoeppe
Copy link
Contributor

@tkoeppe tkoeppe commented Aug 1, 2014

There is no "bold italic teletype" font. This produces a LaTeX warning and a font replacement.

The next best thing is "bold slanted teletype", which this change introduces.

@zygoloid
Copy link
Member

I'd like to investigate other formatting options here. In the first case at least, I'm not sure the boldness is helpful.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Sep 15, 2014

That's a good point; the typographic choice here may benefit from a review, and in that case we can discard this PR.

@vermiculus
Copy link

At any rate, the format should be abstracted into what it really means – such an abstraction should eventually be a part of this PR.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Apr 14, 2015

Do we have any further plans here? If not, could the present PR be applied as a small-increment improvement?

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Nov 19, 2015

Updated this to use the b series rather than the non-existing bx series.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Nov 19, 2015

Reverted to \textbf. The substitution from bx to b is a "silent substitution" that is WAI, and similar silent substitutions happen elsewhere in the document (e.g whenever there is code in a heading).

@vermiculus
Copy link

Please implement a macro that gives this construct some semantic meaning.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Nov 19, 2015

Actually, I don't think the bolding helps at all. The goal of marking the code as a "placeholder" is served perfectly well with a plain italic. I think with this change it's simple enough and we can keep the \textit around as is.

I also found another place were it could be applied.

LaTeX "missing font" warning and is also perfectly sufficient to mark
"variable code". Apply consistently to a second use case, too.
@zygoloid
Copy link
Member

zygoloid commented Dec 9, 2015

I agree with @vermiculus that we should have a macro for this kind of thing; a quick search for other bitmask types shows that they use a bare \textit{...}, which is what our \placeholder{...} expands to. That's covered by at least one of #553, #326, and #319 =)

Let's get this change in to fix the presentation and leave the cleanup to the other issues.

zygoloid added a commit that referenced this pull request Dec 9, 2015
[localization] Change bold-slanted font, removes warning
@zygoloid zygoloid merged commit 073b306 into cplusplus:master Dec 9, 2015
@tkoeppe
Copy link
Contributor Author

tkoeppe commented Dec 9, 2015

If there's interest, I'm happy to make a change that uses \placeholder. But we should be sure that we want that particular macro, or otherwise devise a new one first.

@tkoeppe tkoeppe deleted the latexwarnings branch December 9, 2015 23:40
@vermiculus
Copy link

I'm a pretty deft TeX programmer. Tell me the syntax you want and I'll be happy to implement it in that other issue (can it be referenced here?) 😄

What distribution of TeX Live is being used to compile this? (Use $ tex --version to find out.)

We should also consider other fonts we can use. If you don't already know, all fonts are now fair game.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Dec 11, 2015

@vermiculus: I think we can probably use \placeholder, as zygoloid suggested. It already exists and seems to have the appropriate semantics.

Depending on context we may also like a version of it that disables italic correction, but that's a minor point.

@vermiculus
Copy link

Ah, I didn't realize such a macro already existed 😄

Depending on context we may also like a version of it that disables italic correction, but that's a minor point.

Adding a variant to \placeholder is easy enough (take a look at xparse documentation), but any such markup should have a specific purpose. My question to you would be 'depending on what context?', but that might be a better question to answer off-line or on some instant media. Feel free to email me directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants