Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[module.private.frag] Fix indentation in example #3501

Merged
merged 1 commit into from Nov 25, 2019
Merged

[module.private.frag] Fix indentation in example #3501

merged 1 commit into from Nov 25, 2019

Conversation

JohelEGP
Copy link
Contributor

No description provided.

@JohelEGP
Copy link
Contributor Author

Maybe the change was intentional, given that the language part doesn't follow the guidelines of the library (2 space indentation, in this case).

jensmaurer
jensmaurer approved these changes Nov 22, 2019
View reviewed changes
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm not applying this right now, because we're in the "merge motions" phase.

@zygoloid zygoloid merged commit 5fb67e4 into cplusplus:master Nov 25, 2019
@JohelEGP JohelEGP deleted the module.private.frag branch November 25, 2019 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JohelEGP @jensmaurer @zygoloid