[algorithms] Uniform notation of distance(first, last) to (last - first) #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As allowed in 25.1 [algorithms.general] p12, to express the same things as same.
|
No, this patch is incorrect. The concept of In the one case you noted where |
|
@Quuxplusone see [algorithms.general//12 |
|
I too have a large changeset ready in my private repository that makes [algorithms] more consistent. If there's interest, I can try and merge it with this one? |
|
I agree this change is editorial, and is an improvement, so I'll merge it. @tkoeppe, if you still want to make further changes please make a separate pull request. |
jwakely
added a commit
that referenced
this pull request
Dec 18, 2015
[algorithms] Uniform notation of distance(first, last) to (last - first)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As allowed in 25.1 [algorithms.general] p12, to express the same things
as same.
For is_permutation, it is really bad because last1 - first1 is used in the previous line.
Others are just for consistency.