[algorithms] Fix for a note for conditions of strict-weak-ordering #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as the note says "Under these conditions...". This changes numbering of the items in the note from "(4.2.1) ..." to "(4.3) ...".
|
I think this is a good change, but I wonder if we want this to be a third bullet, or just a new paragraph after the list. |
|
Separating the note as a new paragraph sounds bad, because it might make "these conditions" less clear. Here is the best I got with the "third bullet" idea. The original still looks better for me. |
|
Ah, I misread the patch. I agree the third bullet looks bad. |
jwakely
added a commit
that referenced
this pull request
Apr 16, 2015
[algorithms] Fix for a note for conditions of strict-weak-ordering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the note for both two conditions, not for just the latter of two, as the note says "Under these conditions...".
This changes numbering of the items in the note from "(4.2.1) ..." to "(4.3) ...".