Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[time.syn] Move treat_as_floating_point_v to be right after treat_as_floating_point in the <chrono> synopsis. #3533

Merged
merged 1 commit into from Dec 10, 2019
Merged

[time.syn] Move treat_as_floating_point_v to be right after treat_as_floating_point in the <chrono> synopsis. #3533

merged 1 commit into from Dec 10, 2019

Conversation

brycelelbach
Copy link
Contributor

@brycelelbach brycelelbach commented Dec 9, 2019 •
edited

Today, the synopsis contains the following:

// [time.traits], customization traits
template<class Rep> struct treat_as_floating_point;
template<class Rep> struct duration_values;
template<class Rep>
  inline constexpr bool treat_as_floating_point_v = treat_as_floating_point<Rep>::value;

template<class T> struct is_clock;
template<class T> inline constexpr bool is_clock_v = is_clock<T>::value;

The variable template for is_clock (is_clock_v) is right after is_clock, but for some reason duration_values is currently in between treat_as_floating_point and treat_as_floating_point_v. This editorial change just moves treat_as_floating_point_v to be directly after treat_as_floating_point.

@brycelelbach brycelelbach changed the title Move treat_as_floating_point_v to be right after `treat_as_floating… Move treat_as_floating_point_v to be right after treat_as_floating_point in the <chrono> synopsis. Dec 9, 2019
@JohelEGP
Copy link
Contributor

JohelEGP commented Dec 9, 2019

Please, add [time.syn] to the front of the commit message and issue title.

@brycelelbach
[time.syn] Move treat_as_floating_point_v to be right after `treat_…
b170586 
…as_floating_point` in the `<chrono>` synopsis.
@brycelelbach brycelelbach changed the title Move treat_as_floating_point_v to be right after treat_as_floating_point in the <chrono> synopsis. [time.syn] Move treat_as_floating_point_v to be right after treat_as_floating_point in the <chrono> synopsis. Dec 10, 2019
@brycelelbach
Copy link
Contributor Author

Done

jwakely
jwakely requested changes Dec 10, 2019
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you edit the commit summary please? It's far too long, the backticks are just noise (github doesn't treat commit summary lines as markdown) and "in the <chrono> synopsis" is redundant now that it says [time.syn]. The actual change looks fine though.

@jensmaurer jensmaurer merged commit 93c581c into cplusplus:master Dec 10, 2019
@jensmaurer
Copy link
Member

I've fixed the commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brycelelbach @JohelEGP @jensmaurer @jwakely