Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[thread.condvarany.intwait] missing wait_for() change from P1869R1 #3550

Closed
hadrielk opened this issue Dec 14, 2019 · 0 comments · Fixed by #3583
Closed

[thread.condvarany.intwait] missing wait_for() change from P1869R1 #3550

hadrielk opened this issue Dec 14, 2019 · 0 comments · Fixed by #3583
Assignees

Comments

@hadrielk
Copy link

After P1869R1 was adopted, the condition_variable_any methods wait(), wait_until() and wait_for() argument ordering was changed. This was addressed in issue #3410 and fixed in PR #3448.

However N4842 32.6.4.2 [thread.condvarany.intwait]/13 says:

Effects: Equivalent to:
return wait_until(lock, chrono::steady_clock::now() + rel_time, std::move(pred), std::move(stoken));

Since condition_variable_any::wait_until() now takes the std::stop_token as its second argument, this should instead be:

Effects: Equivalent to:
return wait_until(lock, std::move(stoken), chrono::steady_clock::now() + rel_time, std::move(pred));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants