[range.istream] s/object_/value_/ #3560
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"cjdb wants to merge 575 commits into cplusplus:master" Also, the branch has conflicts. Please rebase and force-push. |
jensmaurer
added
the
needs rebase
|
Strange, I did rebase before branching... okay, will do.
…On Sun, 15 Dec 2019 at 23:25, Jens Maurer ***@***.***> wrote:
"cjdb wants to merge 575 commits into cplusplus:master"
Also, the branch has conflicts. Please rebase and force-push.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3560?email_source=notifications&email_token=ACBZFHADJYCDWFAO6A5RBTDQY24GLA5CNFSM4J3CRNGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG5E7DQ#issuecomment-565858190>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACBZFHDASHRJKN6BNBNST2LQY24GLANCNFSM4J3CRNGA>
.
|
|
Note to self: don't use GitHub's rebase-and-merge for a project as large and actively contributed to as the C++ draft; prefer to do it by hand. |
|
Please rebase and force-push. |
|
@opensdh, @jensmaurer: is this something we want to tackle via piecemeal PRs, or does CWG have plans for "object vs value" already? |
|
I don't think this is in any way related to CWG. This is a consistency question for exposition-only names in the iostreams package of the standard library, nothing else. |
|
Ah indeed, thanks! |
|
Taken via 305443c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @jensmaurer's editorial defect filed to the LWG reflector. I chose to change
object_instead ofvalue_, since it's internally more consistent with the type. If anyoneobject_s to this, I could alternatively rename the strayvalue_in [range.istream.iterator]/7 andValtoT.