Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ranges] Missed kebab-case markings for exposition-only names. #3562

Merged
merged 1 commit into from Dec 18, 2019

Conversation

jensmaurer
Copy link
Member

Fixup for #3559.

@JohelEGP
Copy link
Contributor

Some of the suggestions in the original PR are missing a fix here.

@jensmaurer
Copy link
Member Author

I thought I had them all covered. Anything specific?

@JohelEGP
Copy link
Contributor

Seems like GitHub has problems with big changes. This has happened before. Screenshots to the comments attached.
1576533102
1576533124
1576533145
1576533156
1576533194
1576533202
1576533221
1576533242
1576533252
1576533261
1576533275
1576533281
1576533291
1576533303
1576533323
1576533340
1576533368
1576533377
1576533386
1576533395
1576533409
1576533420

@jensmaurer
Copy link
Member Author

Ok, I hope I got them all this time.

@jensmaurer
Copy link
Member Author

jensmaurer commented Dec 16, 2019

Oh, the index question is still open. I'll fix the spelling, but leave the italics for another day (needs more gymnastics with the indexing macros).

And yes, the question about the inconsistent initialization with the istream iterator stuff is disturbing.

Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 changes. Otherwise, LGTM (other than \placeholder vs \placeholdernc).

source/ranges.tex Outdated Show resolved Hide resolved
@@ -5009,8 +5009,8 @@
\pnum
Let \tcode{\placeholder{inner-range}} be:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Let \tcode{\placeholder{inner-range}} be:
Let \exposid{inner-range} be:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really a placeholder for some code, not an exposition-only member. Leaving as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants