Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ranges] Indented \end{codeblock} causes trailing empty line #3568

Closed
Eelis opened this issue Dec 19, 2019 · 0 comments · Fixed by #3572
Closed

[ranges] Indented \end{codeblock} causes trailing empty line #3568

Eelis opened this issue Dec 19, 2019 · 0 comments · Fixed by #3572

Comments

@Eelis
Copy link
Contributor

Eelis commented Dec 19, 2019

Notice the trailing empty line after the codeblock:
image
This is caused by the fact that the \end{codeblock} is indented:

draft/source/ranges.tex

Lines 485 to 487 in 8166369

\begin{codeblock}
template<class T> void rbegin(T&&) = delete;
\end{codeblock}

[ranges] is the only chapter that has indented \end{codeblock}s:

ranges.tex:354:  \end{codeblock}
ranges.tex:394:  \end{codeblock}
ranges.tex:401:  \end{codeblock}
ranges.tex:407:  \end{codeblock}
ranges.tex:487:  \end{codeblock}
ranges.tex:528:  \end{codeblock}
ranges.tex:535:  \end{codeblock}
ranges.tex:540:  \end{codeblock}
ranges.tex:632:    \end{codeblock}

It might be a good idea to include a rule about this in the specification guidelines wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant