Replace #include by import-declaration #3574
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This example was previously valid, but we've removed the implicit use of header units through #include directives.
jensmaurer
approved these changes
Dec 20, 2019
zygoloid
reviewed
Jan 13, 2020
| @@ -5691,7 +5691,7 @@ | |||
|
|
|||
| \begin{codeblocktu}{Module interface unit of \tcode{C2}} | |||
| module; | |||
| #include "bar.h" // imports header unit \tcode{"bar.h"} | |||
| import "bar.h" // imports header unit \tcode{"bar.h"} | |||
There was a problem hiding this comment.
This is missing the terminating semicolon. (Please also check that the comment starts in a suitable column per https://github.com/cplusplus/draft/wiki/Specification-Style-Guidelines#code-blocks -- looks like we might be missing enforcement of that for codeblocktu.)
zygoloid
added
the
changes requested
|
Please rebase and force-push. |
jensmaurer
added
the
needs rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example was previously valid, but we've removed the implicit use of header units through #include directives.