New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[range.req.general, range.sized] Fix and improve description #3594
Conversation
source/ranges.tex
Outdated
of a \libconcept{range} type that knows its size in constant time with the | ||
\tcode{size} function. | ||
of a \libconcept{range} type that knows its size in constant time with | ||
\tcode{ranges::size}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we maybe fix this a bit more? "knows its size" doesn't sound like a specification, and "with" is a bit non-specific. Maybe "of a range type whose size can be determined in constant time using ranges::size." or so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
93aab34
to
bac8648
Compare
I guess it should say amortized now, right? |
I think this is definitely an improvement, but the addition of "amortized" seems like a normative change. @jwakely What do you think? LWG issue? Or is this not a normative change in your view? |
It's reflecting the normative change we made to the specification of |
OK, I agree that both wording changes are are in not-really-normative introductory sentences, and the change reflects the actual normative wording. On that basis this seems fine. (Would be nice if at least the first changed paragraph here were converted to a note, though that's a separate issue.) |
I like Casey's suggestion, but this seems fine either way. |
No description provided.