Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[range.req.general, range.sized] Fix and improve description #3594

Merged
merged 1 commit into from Mar 13, 2020

Conversation

JohelEGP
Copy link
Contributor

No description provided.

of a \libconcept{range} type that knows its size in constant time with the
\tcode{size} function.
of a \libconcept{range} type that knows its size in constant time with
\tcode{ranges::size}.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we maybe fix this a bit more? "knows its size" doesn't sound like a specification, and "with" is a bit non-specific. Maybe "of a range type whose size can be determined in constant time using ranges::size." or so.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@JohelEGP JohelEGP changed the title [range.sized] Fix description [range.sized] Fix and improve description Dec 30, 2019
@JohelEGP JohelEGP changed the title [range.sized] Fix and improve description [range.sized] Fix and improve wording Jan 4, 2020
source/ranges.tex Outdated Show resolved Hide resolved
@zygoloid zygoloid added the changes requested Changes to the wording or approach have been requested and not yet applied. label Jan 13, 2020
@JohelEGP JohelEGP changed the title [range.sized] Fix and improve wording [range.req.general, range.sized] Fix and improve description Jan 13, 2020
@JohelEGP
Copy link
Contributor Author

JohelEGP commented Mar 7, 2020

I guess it should say amortized now, right?

@jensmaurer jensmaurer removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Mar 12, 2020
@zygoloid zygoloid requested a review from jwakely March 13, 2020 00:07
@zygoloid zygoloid added the lwg Issue must be reviewed by LWG. label Mar 13, 2020
@zygoloid
Copy link
Member

I think this is definitely an improvement, but the addition of "amortized" seems like a normative change.

@jwakely What do you think? LWG issue? Or is this not a normative change in your view?

@CaseyCarter
Copy link
Contributor

I think this is definitely an improvement, but the addition of "amortized" seems like a normative change.

It's reflecting the normative change we made to the specification of sized_range in LWG-3363. Maybe it would be better to avoid the duplication in the first place with a less precise but equally tutorial statement like ...refines \libconcept{range} with the requirement that the number of elements in the range can be determined efficiently using \tcode{ranges::size}?

@zygoloid
Copy link
Member

OK, I agree that both wording changes are are in not-really-normative introductory sentences, and the change reflects the actual normative wording. On that basis this seems fine. (Would be nice if at least the first changed paragraph here were converted to a note, though that's a separate issue.)

@zygoloid zygoloid merged commit 948775f into cplusplus:master Mar 13, 2020
@JohelEGP JohelEGP deleted the range.sized branch March 13, 2020 00:33
@jwakely
Copy link
Member

jwakely commented Mar 13, 2020

I like Casey's suggestion, but this seems fine either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lwg Issue must be reviewed by LWG.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants