Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[format.arg]/5 "otherwise" all at the end #3615

Closed
brevzin opened this issue Jan 9, 2020 · 0 comments · Fixed by #3620
Closed

[format.arg]/5 "otherwise" all at the end #3615

brevzin opened this issue Jan 9, 2020 · 0 comments · Fixed by #3620
Assignees

Comments

@brevzin
Copy link
Contributor

brevzin commented Jan 9, 2020

We have a bulleted list that reads:

5 Effects:
(5.1) if T is bool or char_­type, initializes value with v; otherwise,
(5.2) if T is char and char_­type is wchar_­t, initializes value with static_­cast<wchar_­t>(v); otherwise,
(5.3) if T is a signed integer type ([basic.fundamental]) and sizeof(T) <= sizeof(int), initializes value with static_­cast(v); otherwise,
(5.4) if T is an unsigned integer type and sizeof(T) <= sizeof(unsigned int), initializes value with static_­cast(v); otherwise,
(5.5) if T is a signed integer type and sizeof(T) <= sizeof(long long int), initializes value with static_­cast(v); otherwise,
(5.6) if T is an unsigned integer type and sizeof(T) <= sizeof(unsigned long long int), initializes value with static_­cast(v); otherwise,
(5.7) initializes value with handle(v).

The otherwises are all the end of the bullets. Normally, we put the otherwises at the beginning of the next bullet. I don't think there's a reason for this case to be different - and it kind of reads like we're unconditionally initializing value with handle(v).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants