Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[thread.sema] PascalCase for template parameters #3616

Closed
wants to merge 1 commit into from
Closed

[thread.sema] PascalCase for template parameters #3616

wants to merge 1 commit into from

Conversation

frederick-vs-ja
Copy link
Contributor

Relpace least_max_value with LeastMaxValue which is more consistent with rest of the standard.

@frederick-vs-ja
[thread.sema] PascalCase for template parameters
3a13a2f 
Relpace `least_max_value` with `LeastMaxValue` which is more consistent wity rest of the standard.
jensmaurer
jensmaurer reviewed Jan 10, 2020
View reviewed changes
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[rand.synopsis] also has lowercase names for non-type template parameters. Also, values are lowercase in the standard (e.g. exposition-only members). I'm mildly against the suggested change.

@zygoloid zygoloid added the decision-required A decision of the editorial group (or the Project Editor) is required. label Jan 13, 2020
@zygoloid
Copy link
Member

I'm mildly in favor (we capitalize the N parameter to std::array, the I parameter to tuple get, the N and D parameters to ratio, and so on, but those are all single-letter cases which could be argued as being different from this). Types are lowercase in the standard too, but we capitalize template type parameters.

@frederick-vs-ja frederick-vs-ja mentioned this pull request Jan 20, 2020
Closed
@jensmaurer
Copy link
Member

Editorial meeting: Covered by #3642.

@jensmaurer jensmaurer closed this Feb 10, 2020
@frederick-vs-ja frederick-vs-ja deleted the patch-3 branch June 2, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensmaurer jensmaurer jensmaurer left review comments

Assignees
No one assigned
Labels
decision-required A decision of the editorial group (or the Project Editor) is required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frederick-vs-ja @zygoloid @jensmaurer