Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dcl.attr] Introduce 'Recommended practice' paragraphs. #3628

Merged
merged 1 commit into from Feb 14, 2020
Merged

[dcl.attr] Introduce 'Recommended practice' paragraphs. #3628

merged 1 commit into from Feb 14, 2020

Conversation

jensmaurer
Copy link
Member

Fixes #2978.

@zygoloid zygoloid added cwg Issue must be reviewed by CWG. and removed cwg Issue must be reviewed by CWG. labels Jan 13, 2020
@zygoloid
Copy link
Member

@jensmaurer Please can you mail the CWG reflector just to draw people's attention to this change so that this style can be used going forward?

@zygoloid zygoloid added cwg Issue must be reviewed by CWG. and removed cwg Issue must be reviewed by CWG. labels Jan 13, 2020
@zygoloid
Copy link
Member

Actually... let's get CWG to look over this before applying it. Converting "may" to "should", while not introducing a requirement, does introduce a recommendation, and that seems like something for which we should ask for oversight.

@jensmaurer
Copy link
Member Author

Reference to CWG e-mail: http://lists.isocpp.org/core/2020/01/8153.php

tvaneerd
tvaneerd reviewed Jan 13, 2020
View reviewed changes
source/intro.tex Outdated
Comment on lines 604 to 605
Throughout this document,
non-normative encouragement for implementations is introduced by \recommended.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds pretty definitive. Are you implying all instances of non-normative encouragement? What about all the places we missed, and are still in notes or wherever?

@zygoloid zygoloid merged commit 43876c3 into cplusplus:master Feb 14, 2020
@zygoloid
Copy link
Member

Approved by CWG 2020-02-14.

@zygoloid zygoloid removed the cwg Issue must be reviewed by CWG. label Feb 14, 2020
@jensmaurer jensmaurer deleted the c39 branch February 16, 2020 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvaneerd tvaneerd tvaneerd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[dcl.attr.*] and Recommended Practice
3 participants
@jensmaurer @zygoloid @tvaneerd