Use "requirement" in grammar font in expr.prim.req #3648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
reviewed
Jan 23, 2020
jensmaurer
reviewed
Jan 23, 2020
jensmaurer
added
the
changes requested
|
You change some "s" in places that weren't previously in scope for this pull request (ok), but you didn't change the "s" things for the stuff that you originally changed here. That's not really progress. |
|
Sorry. Learning git pull requests and tex at the same time... |
jensmaurer
removed
the
changes requested
jensmaurer
approved these changes
Jan 24, 2020
[expr.prim.req] uses grammarterm <em><code>requirement</code></em> in paragraph 5, but normal font in paragraph 6. Term "requirement" is never defined in this clause, but it has a different meaning in the library.
|
There's no need for braces around or near the |
|
(Braces were required in former times due to LaTeX-isms.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[expr.prim.req] uses grammarterm
requirementin paragraph 5, but normal font in paragraph 6. Term "requirement" is never defined in this clause, but it has a different meaning in the library.