Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

take_while_view::sentinel declaration is missing the Pred parameter #3666

Closed
zygoloid opened this issue Feb 10, 2020 · 4 comments
Closed

take_while_view::sentinel declaration is missing the Pred parameter #3666

zygoloid opened this issue Feb 10, 2020 · 4 comments
Assignees
@CaseyCarter

Comments

@zygoloid
Copy link
Member

zygoloid commented Feb 10, 2020 •
edited

We have

namespace std::ranges {
  template<view V, class Pred>
  requires input_range<V> && is_object_v<Pred> &&
  indirect_unary_predicate<const Pred, iterator_t<V>>
class take_while_view

but

namespace std::ranges {
    template<class V>
    template<bool Const>
    class take_while_view<V>::sentinel {

(missing the second template argument and the requires-clause).
@CaseyCarter
Copy link
Contributor

Ack! Thanks for the reminder: this problem is endemic throughout [ranges]. Feel free to assign to me.

@JohelEGP
Copy link
Contributor

This was fixed: https://github.com/cplusplus/draft/pull/3604/files.

@CaseyCarter
Copy link
Contributor

CaseyCarter commented Feb 19, 2020 •
edited

This was fixed: https://github.com/cplusplus/draft/pull/3604/files.

That adds the template parameter Pred, but not the missing type-constraint and requires-clause. (Not to mention the other ~12 occurrences in the clause.)

CaseyCarter added a commit to CaseyCarter/draft that referenced this issue Feb 19, 2020
@CaseyCarter
[ranges] Correct outer template-head to match primary template constr…
52017a1 
…aints

Fixes cplusplus#3666.
CaseyCarter added a commit to CaseyCarter/draft that referenced this issue Feb 20, 2020
@CaseyCarter
[ranges] Correct outer template-heads to match primary template const…
2779090 
…raints

Fixes cplusplus#3666.
@zygoloid
Copy link
Member Author

Fixed in 85121a2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CaseyCarter CaseyCarter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zygoloid @CaseyCarter @JohelEGP