Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2020-02 LWG Poll 16] P1976R2 Fixed-size span construction from dynamic range #3718

Closed
jensmaurer opened this issue Feb 16, 2020 · 1 comment · Fixed by #3772
Closed

[2020-02 LWG Poll 16] P1976R2 Fixed-size span construction from dynamic range #3718

jensmaurer opened this issue Feb 16, 2020 · 1 comment · Fixed by #3772
Assignees
@jwakely
Milestone
post-2020-02

Comments

@jensmaurer
Copy link
Member

resolves PL250
@jensmaurer jensmaurer added this to the post-2020-02 milestone Feb 16, 2020
@jwakely
Copy link
Member

jwakely commented Feb 18, 2020

Upon implementing this change I discovered it makes some other parts of the span spec ill-formed, due to return { ... }; statements that use a constructor which is now explicit.

Since the spec is now contradictory, but the intention is clear, I think we should editorially add explicit types to [span.sub] p3 and p6, and [span.objectrep] p1 and p3.

If nobody objects to doing that, I'll take this issue and include those fixes.

@jwakely jwakely self-assigned this Feb 18, 2020
jwakely added a commit that referenced this issue Feb 20, 2020
@jwakely
P1976R2 Fixed-size span construction from dynamic range
e2af9b7 
[span.sub] p3 and p6: Add explicit return types to account for
constructor being explicit now.

[span.objectrep] p1 and p3: Move extent of return type into a remark.
Add explicit return type to account for explicit constructor.

Fixes #3718
Fixes cplusplus/papers#707
Fixes cplusplus/nbballot#246
@jwakely jwakely mentioned this issue Feb 20, 2020
Merged
jwakely added a commit that referenced this issue Feb 20, 2020
@jwakely
P1976R2 Fixed-size span construction from dynamic range
8abef76 
Also fixes NB PL 250  (C++20 CD).

[span.sub] p3 and p6: Add explicit return types to account for
constructor being explicit now.

[span.objectrep] p1 and p3: Move extent of return type into a remark.
Add explicit return type to account for explicit constructor.

Fixes #3718
Fixes cplusplus/papers#707
Fixes cplusplus/nbballot#246
jwakely added a commit that referenced this issue Feb 21, 2020
@jwakely
P1976R2 Fixed-size span construction from dynamic range
14c9f7e 
Also fixes NB PL 250  (C++20 CD).

[span.sub] p3 and p6: Add explicit return types to account for
constructor being explicit now.

[span.objectrep] p1 and p3: Change return type to 'auto' and use
codeblock for effects, with explicit return types to account for
explicit constructor in fixed-extent case.

Fixes #3718
Fixes cplusplus/papers#707
Fixes cplusplus/nbballot#246
jwakely added a commit that referenced this issue Feb 21, 2020
@jwakely
P1976R2 Fixed-size span construction from dynamic range
0780bb6 
Also fixes NB PL 250  (C++20 CD).

[span.sub] p3 and p6: Add explicit return types to account for
constructor being explicit now.

[span.objectrep] p1 and p3: Change return type to 'auto' and use
codeblock for effects, with explicit return types to account for
explicit constructor in fixed-extent case.

Fixes #3718
Fixes cplusplus/papers#707
Fixes cplusplus/nbballot#246
zygoloid pushed a commit that referenced this issue Mar 3, 2020
@jwakely @zygoloid
P1976R2 Fixed-size span construction from dynamic range
e2001f8 
Also fixes NB PL 250  (C++20 CD).

[span.sub] p3 and p6: Add explicit return types to account for
constructor being explicit now.

[span.objectrep] p1 and p3: Change return type to 'auto' and use
codeblock for effects, with explicit return types to account for
explicit constructor in fixed-extent case.

Fixes #3718
Fixes cplusplus/papers#707
Fixes cplusplus/nbballot#246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwakely jwakely

Labels
None yet
Projects
None yet
Milestone
post-2020-02
Development

Successfully merging a pull request may close this issue.

LWG Poll 16: P1976R2 Fixed-size span construction from dynamic range cplusplus/draft
2 participants
@jwakely @jensmaurer