Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library index is missing many enumerators #3731

Open
AlisdairM opened this issue Feb 17, 2020 · 6 comments
Open

Library index is missing many enumerators #3731

AlisdairM opened this issue Feb 17, 2020 · 6 comments
Milestone
C++26

Comments

@AlisdairM
Copy link
Contributor

May be related to #2972 but I think that is only about the main index.

The library contains a variety of enumerations, or bitfield/mask types that provide names like an enumeration. However, many of the enumerator names, while essentially reserved for use in such library contexts (users cannot name macros the same, etc.), are not listed in the library index.

My search is far from exhaustive, but I started from Annex D code_cvt mode enumerators, and then noticed most/all of the bitfields and bit masks in ios_base are missing, and then filed this ticket.

If we do add these names, how should we describe/index them? As members of their enumerator/surrounding class? Under their own name with an ref back to their host?

Given late filing and potential scale, this issue probably should not be considered before C++23 work starts.
@jensmaurer jensmaurer added this to the C++23 milestone Mar 10, 2020
@jensmaurer jensmaurer added the decision-required A decision of the editorial group (or the Project Editor) is required. label May 29, 2020
@jensmaurer
Copy link
Member

I would say we should index them as if the enumeration were a class and the enumerators were class members. However, some/all enumerations are members of some class, and the non-scoped enumeration names often don't actually show up in source code (because they are transparent).

@jensmaurer
Copy link
Member

Editorial meeting: Index enumerators as members of the enumeration "class".

@jensmaurer jensmaurer removed the decision-required A decision of the editorial group (or the Project Editor) is required. label May 28, 2021
@AlisdairM
Copy link
Contributor Author

Sorry, just picking this up again now.
I expect there are enough enumerations scattered through the standard that we should pick this up as an early piece of C++26 work, but shout if you want me to file PRs after all the C++23 papers have landed. (I do not have any PRs in waiting)

@AlisdairM
Copy link
Contributor Author

Ping!

This issue is still marked as C++23. Should I plan to file PRs over the weekend (April 1/2) or should we update the tag to C++26?

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 28, 2023

I don't feel strongly. If you have time, go ahead and make the PRs, and chances are we can apply them for 23.

@jensmaurer jensmaurer modified the milestones: C++23, C++26 Oct 23, 2023
@AlisdairM
Copy link
Contributor Author

Jens got started ahead of me: #7327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
C++26
Development

No branches or pull requests
3 participants
@AlisdairM @tkoeppe @jensmaurer