Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[thread.sharedtimedmutex.class] formatting not consistent with similar cases #374

Closed
zygoloid opened this issue Aug 22, 2014 · 0 comments
Closed

Comments

@zygoloid
Copy link
Member

DIS 14882:2014 NB comment JP 14:

In 30.4.1.4.1:

Formatting for class shared_timed_mutex is not compatible with others.
In addition, at lock() function line, there is a comment, “//blocking”, but in the similar class, timed_mutex, there’s no comment for lock() function. They should be uniformed.

Proposed change:

Remove a blank line under “namespace std{“.
Indent whole class definition by 2 columns.
Remove the comment at lock() and lock_shared().
(or add the same comment at timed_mutex::lock() )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant