Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LWG Poll 3: P2117R0 C++ Standard Library Issues Resolved Directly In Prague #3749

Merged
merged 65 commits into from Feb 28, 2020

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Feb 19, 2020

Notes/issues:

  • This was based on branch motions-2020-02-lwg-2 in order to resolve conflicts which would otherwise arise.
  • LWG3247 not applied; conflicts with wording in LWG3299 (contacted lwgchair)
  • LWG3269 [time.parse]/p3 Fixed wording in list of constraints by adding "has" before "value is".
  • LWG3334 What about function declarations which are still in synopsis [syncstream.osyncstream.overview]?
  • LWG1203 I don't see that the modified operators were ever declared in class basic_istream - why is that? Note also that the referenced text was modified by other issues.
  • LWG3314 Wording in [time.duration.io] conflicts with that of LWG3317; applied anyway.
    ** Edit issue: \impldef may need work; Latex can't handle my attempts at:
\impldef{whether \tcode{\placeholder{units_suffix}} is \tcode{"\textmu{}s"} or \tcode{"us"} when \tcode{Period::type} is \tcode{micro}}
\impldef{whether the unit suffix is \tcode{"\textmu{}s"} or \tcode{"us"} when \tcode{Period::type} is \tcode{micro}}

Fixes #3705.
Fixes cplusplus/nbballot#371.
Fixes cplusplus/nbballot#269.
Fixes cplusplus/nbballot#270.
Fixes cplusplus/nbballot#226.
Fixes cplusplus/nbballot#151.
Fixes cplusplus/nbballot#167.
Fixes cplusplus/nbballot#280 (LWG3281 was superseded by LWG3282).
Fixes cplusplus/nbballot#281.

@jensmaurer jensmaurer changed the title Motions 2020 02 lwg 3 LWG Poll 3: P2117R0 C++ Standard Library Issues Resolved Directly In Prague Feb 19, 2020
@jensmaurer jensmaurer added this to the post-2020-02 milestone Feb 19, 2020
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/utilities.tex Show resolved Hide resolved
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please augment each commit description with a "Also fixes NB US xxx (C++20 CD)." where applicable.

For example, LWG3328 fixes NL 375.
This is recorded in the source paper as "Addresses NL 375".

This is probably a situation where a force-push is desirable, despite these being straw-polls papers.

@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Feb 21, 2020
@jensmaurer
Copy link
Member

LWG 3282 also fixes US 285, but is not marked as such.

@burblebee burblebee removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Feb 22, 2020
@zygoloid zygoloid force-pushed the motions-2020-02-lwg-3 branch 2 times, most recently from 9585655 to 24a0b15 Compare February 27, 2020 02:59
Dawn Perchik and others added 17 commits February 27, 2020 13:52
Merged with P1721R2, which also converted the Remarks: element to a
Constraints: element, but with a more consistent wording pattern.
…metic from pointer-interconvertible object
…ime<Duration2, TimeZonePtr2>

[time.zone.zonedtime.ctor] Inserted "the type" before the non-functions
in the constraints because otherwise the wording
"the return type of f(A) and B" can be parsed in a way that makes no sense.
Dawn Perchik added 27 commits February 27, 2020 17:56
[iterator.concept.winc] Fix "Expressions" to be singular when refering to "E".
[range.refinements] Removed redundant parens and added missing "is true".
@zygoloid zygoloid merged commit 1f642ba into master Feb 28, 2020
@jensmaurer jensmaurer deleted the motions-2020-02-lwg-3 branch February 12, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment