LWG Poll 14: P1868R2 🦄 width: clarifying units of width and precision in std::format #3753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
changed the title
jensmaurer
changed the title
burblebee
pushed a commit
that referenced
this pull request
Feb 23, 2020
burblebee
pushed a commit
that referenced
this pull request
Feb 24, 2020
jensmaurer
reviewed
Feb 25, 2020
jensmaurer
added
the
changes requested
burblebee
removed
the
changes requested
zygoloid
reviewed
Mar 3, 2020
source/utilities.tex
Outdated
| @@ -19935,6 +19935,8 @@ | |||
| the first code points in its extended grapheme clusters | |||
| as defined by | |||
| Unicode Standard Annex \#29 Unicode Text Segmentation. | |||
|
|
|||
| \begin{example} | |||
There was a problem hiding this comment.
I believe this is the definition of "estimated width", not an example.
The "as defined by" is referring only to "extended grapheme clusters" (which are defined by Annex #\29), not to "estimated width" (which is not defined by Annex #\29).
There was a problem hiding this comment.
@zygoloid, a later commit corrects this.
There was a problem hiding this comment.
The example markers were still present at the tip of the branch. I've removed them now. (Maybe they were removed and re-added before I got here?)
zygoloid
force-pushed
the
motions-2020-02-lwg-14
branch
3 times, most recently
from
cf53de4
to
fa0a365
Compare
Also fixes NB US 228 (C++20 CD) and LWG3290.
…apse two adjacent code points into a range.
zygoloid
force-pushed
the
motions-2020-02-lwg-14
branch
from
fa0a365
to
9ce9b23
Compare
zygoloid
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3716.
Fixes cplusplus/papers#618.
Fixes cplusplus/nbballot#225.