LWG Poll 23: P2106R0 Alternative wording for GB315 and GB316 #3774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohelEGP
suggested changes
Feb 20, 2020
source/algorithms.tex
Outdated
|
|
||
| template<class II1, class II2, class OO> | ||
| requires convertible_to<const I1&, II1> && | ||
| convertible_to<const I2&, II2> && convertible_to<const O&, OO> |
There was a problem hiding this comment.
Suggested change
| convertible_to<const I2&, II2> && convertible_to<const O&, OO> | |
| convertible_to<const I2&, II2> && convertible_to<const O&, OO> |
https://github.com/cplusplus/draft/pull/3750/files formats it like this. This occurs below too.
There was a problem hiding this comment.
FWIW, I use that style in #3750 because I'm under the impression that the editors prefer it. It is notably similar to how we indent run-on lines for template parameters.
|
Let me try to close and reopen this to trigger Travis. |
CaseyCarter
reviewed
Feb 21, 2020
source/algorithms.tex
Outdated
|
|
||
| template<class II1, class II2, class OO> | ||
| requires convertible_to<const I1&, II1> && | ||
| convertible_to<const I2&, II2> && convertible_to<const O&, OO> |
There was a problem hiding this comment.
FWIW, I use that style in #3750 because I'm under the impression that the editors prefer it. It is notably similar to how we indent run-on lines for template parameters.
jensmaurer
changed the title
tkoeppe
added
the
changes requested
tkoeppe
approved these changes
Mar 3, 2020
zygoloid
force-pushed
the
motions-2020-02-lwg-23
branch
from
fc7ed67
to
915c610
Compare
Also fixes NB GB 315 and NB GB 316.
zygoloid
force-pushed
the
motions-2020-02-lwg-23
branch
from
915c610
to
da3b710
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes NB GB 315 and NB GB 316.
Fixes #3725 .
Fixes cplusplus/nbballot#311.
Fixes cplusplus/nbballot#312.
Open issues: