Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LWG Poll 19: P0586R2 Safe integral comparisons #3779

Merged
merged 1 commit into from Mar 3, 2020
Merged

LWG Poll 19: P0586R2 Safe integral comparisons #3779

merged 1 commit into from Mar 3, 2020

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Feb 21, 2020 •
edited by jensmaurer

Also fixes NB DE 208 (C++20 CD).

Fixes #3721.
Fixes cplusplus/papers#259.
Fixes cplusplus/nbballot#206.

JohelEGP
JohelEGP suggested changes Feb 21, 2020
View reviewed changes
source/utilities.tex Outdated Show resolved Hide resolved
timsong-cpp
timsong-cpp reviewed Feb 21, 2020
View reviewed changes
source/support.tex Outdated Show resolved Hide resolved
jwakely
jwakely requested changes Feb 21, 2020
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature test macro is not what we approved in plenary, and the subclause heading should change for the same reason as the macro changed.

@jensmaurer jensmaurer added this to the post-2020-02 milestone Feb 21, 2020
@jensmaurer jensmaurer changed the title P0586R2 Safe integral comparisons LWG Poll 19: P0586R2 Safe integral comparisons Feb 21, 2020
@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Feb 21, 2020
burblebee pushed a commit that referenced this pull request Feb 23, 2020
[utility][version] Change wording added in P0586R2 as suggested in #3779
724c9a8 


* [utility.syn][utility.safeintcmp] Replace "safe integral comparisons" with "integer comparison functions"
* [version.syn] Replace __cpp_lib_cmp_equal with __cpp_lib_integer_comparison_functions
@burblebee burblebee removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Feb 23, 2020
timsong-cpp
timsong-cpp reviewed Feb 23, 2020
View reviewed changes
source/utilities.tex Outdated Show resolved Hide resolved
@zygoloid zygoloid force-pushed the motions-2020-02-lwg-19 branch 2 times, most recently from 693ffe0 to 78611a6 Compare March 3, 2020 02:45
@zygoloid
P0586R2 Safe integral comparisons
1e329ff 
Also rename feature test macro __cpp_lib_cmp_equal to
__cpp_lib_integer_comparison_functions.

Also fixes NB DE 208 (C++20 CD).
@zygoloid zygoloid merged commit e664a2c into master Mar 3, 2020
@jensmaurer jensmaurer deleted the motions-2020-02-lwg-19 branch February 12, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timsong-cpp timsong-cpp timsong-cpp left review comments

@JohelEGP JohelEGP JohelEGP requested changes

@jwakely jwakely Awaiting requested review from jwakely

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2020-02
6 participants
@burblebee @jwakely @timsong-cpp @JohelEGP @zygoloid @jensmaurer