LWG Poll 4: P2045R1 Missing Mandates for the standard library #3781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
added
the
changes requested
|
see Travis failures |
This comment has been minimized.
This comment has been minimized.
jensmaurer
changed the title
burblebee
removed
the
changes requested
zygoloid
force-pushed
the
motions-2020-02-lwg-4
branch
from
2e7e402
to
26d7a20
Compare
timsong-cpp
reviewed
Feb 28, 2020
| @@ -5132,12 +5135,12 @@ | |||
|
|
|||
| \begin{itemdescr} | |||
| \pnum | |||
| \requires \tcode{*this} refers to a suspended coroutine. | |||
| \expects | |||
| \tcode{*this} refers to a suspended coroutine. | |||
There was a problem hiding this comment.
There's a missing change here.
The coroutine is not suspended at its final suspend point.
zygoloid
force-pushed
the
motions-2020-02-lwg-4
branch
from
26d7a20
to
08022bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3706.
Fixes cplusplus/papers#775.