New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LWG Poll 22: P1243R4 Rangify New Algorithms #3783
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made some suggestions for improvements, but this PR does correctly make the changes as directed by the ingress paper.
@CaseyCarter's cleanup suggestions should go into a separate pull request, because the review committee wants to see the "original" applications first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to submit this.
Oops, didn't see this until after I pushed. That said, Casey's suggestions don't appear to rise to the level that they warrant a separate commit IMHO. FWIW I've made similar FIXUPs to other papers for similar cosmetic changes. |
I agree, the fixups in this branch are not observable as far as the moved wording goes; they only exercise presentational discretion. |
45d665a
to
8d2e68d
Compare
Also fixes NB FR 305, US 318, and US 307 (C++20 CD).
8d2e68d
to
f6f2113
Compare
Also fixes NB FR 305, US 318, and US 307 (C++20 CD).
Fixes #3724.
Fixes cplusplus/papers#152
Fixes cplusplus/nbballot#301.
Fixes cplusplus/nbballot#314.
Fixes cplusplus/nbballot#303.
Notes:
for_each_n
declaration).