Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LWG Poll 22: P1243R4 Rangify New Algorithms #3783

Merged
merged 1 commit into from Mar 4, 2020
Merged

Conversation

burblebee
Copy link
Contributor

@burblebee burblebee commented Feb 21, 2020

Also fixes NB FR 305, US 318, and US 307 (C++20 CD).

Fixes #3724.
Fixes cplusplus/papers#152
Fixes cplusplus/nbballot#301.
Fixes cplusplus/nbballot#314.
Fixes cplusplus/nbballot#303.

Notes:

  • [alg.foreach] FYI: the referenced "Remarks:" is paragraph p27 (after the 2nd for_each_n declaration).

Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some suggestions for improvements, but this PR does correctly make the changes as directed by the ingress paper.

source/algorithms.tex Outdated Show resolved Hide resolved
source/algorithms.tex Outdated Show resolved Hide resolved
source/algorithms.tex Outdated Show resolved Hide resolved
source/algorithms.tex Show resolved Hide resolved
@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Feb 21, 2020
@jensmaurer
Copy link
Member

@CaseyCarter's cleanup suggestions should go into a separate pull request, because the review committee wants to see the "original" applications first.

@jensmaurer jensmaurer added this to the post-2020-02 milestone Feb 21, 2020
Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to submit this.

source/algorithms.tex Outdated Show resolved Hide resolved
burblebee pushed a commit that referenced this pull request Feb 23, 2020
@burblebee
Copy link
Contributor Author

@CaseyCarter's cleanup suggestions should go into a separate pull request, because the review committee wants to see the "original" applications first.

Oops, didn't see this until after I pushed. That said, Casey's suggestions don't appear to rise to the level that they warrant a separate commit IMHO. FWIW I've made similar FIXUPs to other papers for similar cosmetic changes.

@burblebee burblebee removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Feb 23, 2020
source/algorithms.tex Outdated Show resolved Hide resolved
@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 3, 2020

I agree, the fixups in this branch are not observable as far as the moved wording goes; they only exercise presentational discretion.

@tkoeppe tkoeppe self-requested a review March 3, 2020 22:03
Also fixes NB FR 305, US 318, and US 307 (C++20 CD).
@zygoloid zygoloid merged commit 54a2e6a into master Mar 4, 2020
@jensmaurer jensmaurer deleted the motions-2020-02-lwg-22 branch February 12, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants