Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[alg.clamp] Reword for clarity #3785

Closed
wants to merge 1 commit into from

Conversation

CaseyCarter
Copy link
Contributor

Define comp and proj for the overloads with no such parameters and spell out the meaning of the handwavy "is no greater than" and "is less than".

(To be rebased and applied after motions-2020-02-lwg-22.)

@jensmaurer jensmaurer added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Mar 6, 2020
@jensmaurer
Copy link
Member

This says "draft pull request". (I didn't know such a thing existed.)

Anyway, please do what needs to be done to make this ready.

Define `comp` and `proj` for the overloads with no such parameters and spell out the meaning of the handwavy "is no greater than" and "is less than".

(To be rebased and applied after motions-2020-02-lwg-22.)
@CaseyCarter CaseyCarter marked this pull request as ready for review March 8, 2020 00:28
@CaseyCarter
Copy link
Contributor Author

Anyway, please do what needs to be done to make this ready.

Done.

@jensmaurer jensmaurer removed the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Mar 12, 2020
@CaseyCarter CaseyCarter deleted the clamp branch March 12, 2020 22:38
@jensmaurer
Copy link
Member

@CaseyCarter , why did you close this? This seems still relevant.

@CaseyCarter
Copy link
Contributor Author

@CaseyCarter , why did you close this? This seems still relevant.

I managed to convince myself this had been applied and removed the branch. I'll have to open another PR - Github refuses to reopen this one since the branch was recreated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants