Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for 2020-02 CWG Poll 1 #3796

Merged
merged 1 commit into from Mar 4, 2020
Merged

Conversation

zygoloid
Copy link
Member

Improvements inspired by a comment from @hubert-reinterpretcast on #3782.

definition of "transparently replaceable" and simplify the exposition a
little.
\item the original object is neither
a complete object that is const-qualified nor
a subobject of such an object, and
\item $o_1$ is not a complete const object, and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the following is almost as brief and a more direct adaptation of the existing bullet:

Suggested change
\item $o_1$ is not a complete const object, and
\item the complete object of $o_1$ is not a const object, and

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The question is, do we want to check for a const complete object on every level of the upward recursion, or only when we reach the complete object? The latter seems simpler to me, but I don't feel at all strongly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thinking on this is that it is easier to get this bullet out of the way by checking it first and then ignoring it during the recursion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming "the complete object of x" is x if x is a complete object, it feels that Hubert's formulation is a little clearer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a trade: with the HST wording, we have to do the "complete object of" search in every recursion round.

@zygoloid zygoloid merged commit ce2e915 into master Mar 4, 2020
@jensmaurer jensmaurer deleted the motions-2020-02-cwg-1-fixes branch February 12, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants