[time.format] Add/fix region-index entry for "format" #3821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
reviewed
Mar 6, 2020
jensmaurer
reviewed
Mar 6, 2020
| @@ -10938,7 +10939,6 @@ | |||
| }; | |||
| \end{codeblock} | |||
|
|
|||
| % FIXME: Decide how to index this. This template-id is a lie. | |||
There was a problem hiding this comment.
Now you've removed this totally unrelated FIXME.
Could I ask you limit this change to just the indexing snafu? Thanks.
There was a problem hiding this comment.
This is the snafu. It's a previously known one, just not one that was previously resolved...
jensmaurer
requested changes
Mar 6, 2020
|
Ah, that was where the "see below" pointed to. Anyway, please create separate github issues for any follow-up tasks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't tell what the perceived problem behind the
FIXMEwas; I'd welcome feedback; @AlisdairM?