Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[front.insert.iterator] Correct mis-incorporation of P0896R4 #3825

Merged
merged 1 commit into from Mar 6, 2020
Merged

[front.insert.iterator] Correct mis-incorporation of P0896R4 #3825

merged 1 commit into from Mar 6, 2020

Conversation

CaseyCarter
Copy link
Contributor

What should be a defaulted default constructor is instead an ill-formed defaulted non-default constructor. This appears to be copy pasta from the original merge of P0896R4 in e85af95.

@CaseyCarter
[front.insert.iterator] Correct mis-incorporation of P0896R4
45084e9 
What should be a defaulted default constructor is instead an ill-formed defaulted non-default constructor. This appears to be copy pasta from the original merge of P0896R4 in e85af95.
@JohelEGP
Copy link
Contributor

JohelEGP commented Mar 5, 2020

The constexpr is usually omitted. counted- and common- _iterators also deviate from the norm.

@CaseyCarter
Copy link
Contributor Author

The constexpr is usually omitted.

I don't think we're consistent enough about constexpr being explicit/implicit on defaulted default constructors to have a "usually." That said, I don't particularly care - my primary concern here is to make the smallest possible change to the DIS to unbreak it. If the editors ask me to remove the extraneous constexpr or noexcept I'm happy to do so.

@zygoloid zygoloid merged commit 417053a into cplusplus:master Mar 6, 2020
@CaseyCarter CaseyCarter deleted the front_inserter branch March 6, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CaseyCarter @JohelEGP @jensmaurer @zygoloid