[atomics] Consistent use of enum class memory_order #3832
Merged
+62
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the application of P0439R0, the library wording has been partially updated to use the new scoped enumaration values whenever memory order constants are required, and partially retains use of the inline constants supplied for back compatibility. This patch conistently uses the memory_order::enumerators, retaining the old name only for their declaration, the index, and for Annex C wording on C++17 compatibility, which /should/ use the old spelling.
|
I need help understanding the Travis failure - my local builds all succeed. Which part of the message above indicates the nature of the failure that I need to address? |
|
Looks like the change caused the code block to run into the right margin. |
jensmaurer
added
the
changes requested
The atomic API for shared_ptr has a couple of returns clauses bleeding their trailing period beyond the margin, so revert the whole clause for consistency, allowing the main text edits to proceed.
|
Reverted the changes to Annex D, so at least the text of the main standard can benefit from the update. Need someone more skilled in the art of LaTeX, typography, and the margins, to figure a better solution for the long expressions for a couple of the Returns: clauses in the Annex D deprecated atomic access to shared_ptr API. |
jensmaurer
removed
the
changes requested
jensmaurer
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the application of P0439R0, the library wording has been partially
updated to use the new scoped enumaration values whenever memory order
constants are required, and partially retains use of the inline
constants supplied for back compatibility.
This patch conistently uses the memory_order::enumerators, retaining
the old name only for their declaration, the index, and for Annex C
wording on C++17 compatibility, which /should/ use the old spelling.