Fix incorrect references to past the end pointers #3836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zygoloid
reviewed
Mar 12, 2020
| pointer represents the address one past the last element of a different | ||
| pointer represents the address past the end\iref{basic.compound} of a different |
There was a problem hiding this comment.
This is about the represented address, not the pointer value, so I think this change isn't what we want. Something like this might work, but it's a bit clumsy: "and another pointer represents the same address as a pointer past the end of a different complete object".
There was a problem hiding this comment.
How about "pointer represents the address of a pointer value past the end of a different complete object"
There was a problem hiding this comment.
I think we need "same address" somewhere in the mix.
zygoloid
added
the
changes requested
jensmaurer
added
the
needs rebase
|
I'm inclined to close this suggestion, given that it doesn't work as is, and it's not clear that we know of an actual improvement. Please reopen if you have further thoughts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proper terminology is used and defined in [basic.compound] p3: