[lex.ccon,lex.string] Remove redundant repetition of the grammar. #3844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zygoloid
requested changes
Mar 11, 2020
There was a problem hiding this comment.
I think there's more we should be doing here. String literal concatenation is one mess, UDLs are another. Some of the references to "character literal" and "string literal" mean to include UDLs, others don't. Some references to "string literal" mean before concatenation, others mean afterwards. :-(
zygoloid
reviewed
Mar 11, 2020
zygoloid
reviewed
Mar 11, 2020
zygoloid
reviewed
Mar 11, 2020
zygoloid
reviewed
Mar 11, 2020
Also use the grammar non-terminals character-literal and string-literal throughout the standard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also use the grammar non-terminals character-literal and
string-literal throughout the standard.
Fixes #3636.