Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[support.dynamic] Improve cross-referencing for dynamic memory subcla… #3845

Merged
merged 5 commits into from Mar 12, 2020

Conversation

AlisdairM
Copy link
Contributor

…uses

Update several cross-references to subclause 17.6 with more precise
refernces to subclauses nested one level deeper. For the synopsis
of the header, added a couple of banner comments with cross-references
too.

In addition, looked into ordering the global namespace declarations
in front of opening namespace std to improve clarity, but that fails
due to use of types declared in namespace std by this header!

…uses

Update several cross-references to subclause 17.6 with more precise
refernces to subclauses nested one level deeper.  For the synopsis
of the header, added a couple of banner comments with cross-references
too.

In addition, looked into ordering the global namespace declarations
in front of opening namespace std to improve clarity, but that fails
due to use of types declared in namespace std by this header!
Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Banner comments usually have the same text as the reference's title.

source/support.tex Outdated Show resolved Hide resolved
source/support.tex Outdated Show resolved Hide resolved
source/support.tex Outdated Show resolved Hide resolved
@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Mar 10, 2020
AlisdairM and others added 3 commits March 11, 2020 12:41
Co-Authored-By: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
Co-Authored-By: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
Co-Authored-By: Johel Ernesto Guerrero Peña <johelegp@gmail.com>
@AlisdairM
Copy link
Contributor Author

I had managed to convince myself otherwise, but the counterexamples are few and far between, and mostly dropping a word or two, not rephrasing. Thanks for supplying the fixes too!

@jensmaurer jensmaurer removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Mar 11, 2020
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove trailing whitespace:

support.tex:2008: // \ref{alloc.errors}, storage allocation errors <--- trailing whitespace
support.tex:2040:// \ref{new.delete}, storage allocation and deallocation <--- trailing whitespace

@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Mar 11, 2020
@jensmaurer jensmaurer removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Mar 11, 2020
@zygoloid zygoloid merged commit b83f020 into cplusplus:master Mar 12, 2020
@AlisdairM AlisdairM deleted the improve_xref_for_17_6 branch November 14, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants