Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[range.split.outer], [range.split.inner] Fix misuses of current_ #3849

Merged
merged 1 commit into from Mar 10, 2020
Merged

[range.split.outer], [range.split.inner] Fix misuses of current_ #3849

merged 1 commit into from Mar 10, 2020

Conversation

jwakely
Copy link
Member

@jwakely jwakely commented Mar 10, 2020

This restores references to the 'current' placeholder.

Fixes #3848

@jwakely
[range.split.outer], [range.split.inner] Fix misuses of current_
e04210b 
This restores references to the 'current' placeholder.

Fixes cplusplus#3848
@jwakely jwakely mentioned this pull request Mar 10, 2020
Closed
jensmaurer
jensmaurer approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a mess.

@jwakely
Copy link
Member Author

jwakely commented Mar 10, 2020

What a mess.

Those were my words exactly when I discussed this on IRC 😃

@CaseyCarter
Copy link
Contributor

CaseyCarter commented Mar 10, 2020 •
edited

While this is certainly correct, I think we are just asking to screw this up again if we don't rename one of current or current_ to something more clearly distinct (no, not _current!). I don't have any great ideas, or I wouldn't have used the names current and current_ in the first place. (Even a completely meaningless name like meow would be better than two current s.)

@jensmaurer jensmaurer merged commit bcfa946 into cplusplus:master Mar 10, 2020
@jensmaurer jensmaurer mentioned this pull request Mar 10, 2020
Open
@jensmaurer
Copy link
Member

Let's merge this for now, and discuss long-term remedies in #3851.

@jwakely jwakely deleted the issue-3848 branch January 22, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[range.split] confuses current and current_
3 participants
@jwakely @CaseyCarter @jensmaurer