Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ranges] has many concepts used without \libconcept #3870

Closed
timsong-cpp opened this issue Mar 13, 2020 · 4 comments · Fixed by #4456
Closed

[ranges] has many concepts used without \libconcept #3870

timsong-cpp opened this issue Mar 13, 2020 · 4 comments · Fixed by #4456
Assignees
@jensmaurer

Comments

@timsong-cpp
Copy link
Contributor

e.g.,

  template<input_or_output_iterator I, sentinel_for<I> S, subrange_kind K>
    inline constexpr bool enable_borrowed_range<subrange<I, S, K>> = true;

or

  template<@\libconcept{input_range}@ V, @\libconcept{indirect_unary_predicate}@<iterator_t<V>> Pred>
    requires view<V> && is_object_v<Pred>
  class filter_view;

What's the intended policy for the use of \libconcept?
@JohelEGP
Copy link
Contributor

Must be after some "Editorial meeting:". I wonder if there's a compilation of those, like there's the Specification Style Guidelines.

@CaseyCarter
Copy link
Contributor

#3494 was closed by application of #3496. I suppose the remaining unannotated concept uses were overlooked?

@JohelEGP
Copy link
Contributor

A more recently merged PR had in context a concept use without \libconcept, so I supposed some were introduced since then.

@jensmaurer
Copy link
Member

jensmaurer commented Mar 13, 2020 •
edited

Yes, some of these were overlooked. Maybe I should (temporarily) make \libconcept choose a different color so a lack of marking stands out more.

@jensmaurer jensmaurer mentioned this issue Jan 6, 2021
Merged
@jensmaurer jensmaurer self-assigned this Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jensmaurer jensmaurer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ranges] Improve concept index jensmaurer/draft
4 participants
@CaseyCarter @timsong-cpp @JohelEGP @jensmaurer