[diff.expr] replace "declare" with "define" #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is always legal in C++ to declare new types in a sizeof expression or cast expression, but you can't *define* a new type in an expression.
|
I don't find anything wrong of the original wording. A definition is always a declaration in C++. And is it really always legal, e.g. |
|
The original wording is indeed incorrect, and the suggested change is an improvement. The cross-references to 5.3.3 and 5.4 are also wrong here; the rule is in 7.1.6. There's a collection of other formatting issues near here that I'd also like to fix; I'd like to take a broader look. |
|
@zygoloid should we merge this as is, since it doesn't make anything worse, and is an improvement? |
zygoloid
added a commit
that referenced
this pull request
Mar 7, 2016
[diff.expr] Fix incorrect description of difference between C and C++: it is possible to declare, but (unlike C) not define, new types within expressions in C++.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is always legal in C++ to declare new types in a sizeof expression or cast expression, but you can't define a new type in an expression.