Strike surviving mentions of "storage class" (outside of stable names and grammar) #3906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zygoloid
requested changes
Mar 25, 2020
There was a problem hiding this comment.
Please follow the rules at https://github.com/cplusplus/draft/wiki/Commit-message-format when naming your commits.
zygoloid
added
the
changes requested
sdkrystian
force-pushed
the
patch-45
branch
4 times, most recently
from
91a7d5e
to
ae76dfb
Compare
jensmaurer
reviewed
Apr 10, 2020
jensmaurer
removed
the
changes requested
zygoloid
approved these changes
Sep 18, 2020
zygoloid
reviewed
Oct 18, 2020
zygoloid
added
the
changes requested
jensmaurer
added
the
needs rebase
|
This needs a rebase + force-push, plus a small fix. |
|
@sdkrystian: Ping |
|
@jensmaurer @zygoloid @tkoeppe Apologies for the inactivity, school has kept me very busy and unable to do much wg21 related work. At the end of the semester (little over a week) I'll be able to address everything that needs changes or rebasing. |
|
@sdkrystian: Ping^2 |
|
@sdkrystian: Ping^3 |
…entions of "storage class"
|
@jensmaurer @tkoeppe Very sorry for disappearing for the last few years. Rebased, updated commit message, and applied suggested wording. |
|
No need to apologize! And thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outside of the grammar term and first paragraph of [dcl.stc], "storage class" has no meaning in C++, and has no need to be defined. This replaces mentions of "storage class" with storage-class-specifier, "storage duration" and "linkage" where appropriate.