Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly annotate keywords #3908

Closed
wants to merge 2 commits into from
Closed

Conversation

sdkrystian
Copy link
Contributor

Fixed a few instances of keywords not being properly annotated.

Copy link
Member

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You found a lot of very old wording here :) Sorry for asking for so many drive-by fixes!

source/compatibility.tex Outdated Show resolved Hide resolved
source/basic.tex Outdated Show resolved Hide resolved
source/compatibility.tex Outdated Show resolved Hide resolved
source/compatibility.tex Outdated Show resolved Hide resolved
Comment on lines 2231 to +2234
Explicit declaration is increasingly considered
to be proper style.
Liaison with WG14 (C) indicated support for (at least)
deprecating implicit int in the next revision of C.
deprecating implicit \tcode{int} in the next revision of C.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can say something more current here; it's been a long time since C was considering deprecation.

@AaronBallman What's the status quo with C17 and C2x? Can you suggest something suitable?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implicit int was removed in C99 (WG14 N635 N661 N692 N722), so at this point, we can just say it's incompatible with C.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, we should just drop this entire entry: There is (no longer) any incompatibility, because implicit int is not a thing in (current) C and not in C++. We refer to ISO 9899:2018 in the front matter, btw.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"implicit int" will be removed by #5088

source/locales.tex Outdated Show resolved Hide resolved
source/locales.tex Outdated Show resolved Hide resolved
@zygoloid zygoloid added the changes requested Changes to the wording or approach have been requested and not yet applied. label Mar 25, 2020
@sdkrystian sdkrystian force-pushed the patch-47 branch 2 times, most recently from 3a2fb6e to 9cf45d4 Compare March 26, 2020 00:43
@jensmaurer jensmaurer removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Apr 10, 2020
@jensmaurer
Copy link
Member

Please use \keyword for keywords, which also helps with index entries.

Also, some of the drive-by fixes should be in separate commits.

@sdkrystian
Copy link
Contributor Author

@jensmaurer Sorry! I'll make sure to use \keyword for all future changes (apologies for you having to repeat yourself on 3 different PRs!).

I'll split the drive-by edits into separate commits.

@zygoloid zygoloid added the changes requested Changes to the wording or approach have been requested and not yet applied. label Sep 18, 2020
@jensmaurer jensmaurer added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Oct 29, 2020
@jensmaurer
Copy link
Member

jensmaurer commented Oct 29, 2020

This needs a rebase + force-push, plus some attention to the latest review comments.

@jensmaurer
Copy link
Member

@sdkrystian , ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Changes to the wording or approach have been requested and not yet applied. needs rebase The pull request needs a git rebase to resolve merge conflicts.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants