New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly annotate keywords #3908
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You found a lot of very old wording here :) Sorry for asking for so many drive-by fixes!
Explicit declaration is increasingly considered | ||
to be proper style. | ||
Liaison with WG14 (C) indicated support for (at least) | ||
deprecating implicit int in the next revision of C. | ||
deprecating implicit \tcode{int} in the next revision of C. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can say something more current here; it's been a long time since C was considering deprecation.
@AaronBallman What's the status quo with C17 and C2x? Can you suggest something suitable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implicit int
was removed in C99 (WG14 N635 N661 N692 N722), so at this point, we can just say it's incompatible with C.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, we should just drop this entire entry: There is (no longer) any incompatibility, because implicit int is not a thing in (current) C and not in C++. We refer to ISO 9899:2018 in the front matter, btw.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"implicit int" will be removed by #5088
3a2fb6e
to
9cf45d4
Compare
Please use \keyword for keywords, which also helps with index entries. Also, some of the drive-by fixes should be in separate commits. |
@jensmaurer Sorry! I'll make sure to use \keyword for all future changes (apologies for you having to repeat yourself on 3 different PRs!). I'll split the drive-by edits into separate commits. |
This needs a rebase + force-push, plus some attention to the latest review comments. |
@sdkrystian , ping |
Fixed a few instances of keywords not being properly annotated.