[temp.param] Remove definitions in footnote and fix wording referring to non-type template parameters #3917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to non-type template parameters
jensmaurer
reviewed
Apr 15, 2020
| are used to refer to non-type, non-template parameters and arguments.} | ||
| \grammarterm{parameter-declaration}. | ||
| non-type \grammarterm{template-parameter} and | ||
| non-type \grammarterm{template-argument} |
There was a problem hiding this comment.
I actually think those definitions should be normative and indexed; they are used quite a lot and we shouldn't rely on the "since" rationale offered here for readers to understand a fairly basic term.
There was a problem hiding this comment.
Should we do non-type template-parameter like we do for trailing requires-clause, or non-type template parameter? The former seems to be used more often than the latter.
zygoloid
reviewed
Sep 18, 2020
| @@ -277,17 +277,16 @@ | |||
| \tcode{typename} | |||
| followed by a | |||
| \grammarterm{qualified-id} | |||
| denotes the type in a non-type% | |||
| denotes the type in a \grammarterm{parameter-declaration}.% | |||
There was a problem hiding this comment.
We now have a footnote explaining what we mean by "non-type" attached to wording that doesn't say "non-type". That doesn't seem ideal. But in any case the disambiguation rule for template<class T> seems like a very strange place to be defining "non-type".
jensmaurer
added
the
changes requested
wg21bot
added
the
needs rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some more of those pesky definitions in non-normative text, and has a small drive-by edit to [temp.param] p2 (a parameter-declaration does not declare a type except for certain cases with elaborated-type-specifiers where it kind of does (but not really), but that does not apply in a template-parameter either way).
Also, what is stated in the footnote should probably have corresponding normative wording, since we don't currently have any.