[basic.lval] Dynamic type is not a property of objects #3934
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
requested changes
Apr 15, 2020
|
"static" versus "dynamic" isn't at all relevant here, since we have no accesses of class type. I think I'd prefer to strike the "dynamic" and not add a "static". |
|
Good point; an "access" in C++ is always on a built-in type. |
jensmaurer
added
the
changes requested
|
@jensmaurer Should we take over this PR? It looks like useful cleanup. |
|
Yes, I think there is some cleanup necessary in this area.. |
|
@jensmaurer: Shall we start by just deleting the two instances of "dynamic" here and leaving wider cleanup for a separate effort? |
|
I think I'd prefer a more wholesale approach with CWG review. |
wg21bot
added
the
needs rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not the only place where such wording exists, but fixing other occurrences would require more substantial rewrites.