Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expr.comma] Remove mid-sentence example #3939

Merged
merged 1 commit into from Sep 18, 2020

Conversation

sdkrystian
Copy link
Contributor

Having an example after a comma mid-sentence is horrible (I had to read this several times to realize that it wasn't a sentence fragment).

@sdkrystian sdkrystian force-pushed the patch-67 branch 2 times, most recently from 68f974f to 75f8a9a Compare April 13, 2020 23:07
@W-E-Brown
Copy link
Contributor

Seems like this correctly identifies a problem, but also seems to address it in quite an extreme way.

All that's needed is (as is done elsewhere) to turn the mid-sentence example into a parenthesized phrase that's introduced by 'e.g.' -- let's please not rewrite more than necessary.

@sdkrystian
Copy link
Contributor Author

sdkrystian commented Apr 14, 2020

@W-E-Brown I considered this, but I don't think we need to make this wording normative. If we were to do so, a rephrasing (as done here) would certainly be necessary (it's quite dated and imprecise). I'd argue that it would be the more "extreme" approach, as opposed to moving it to the end where we already have informative wording.

@timsong-cpp
Copy link
Contributor

Do we even need a normative statement here? Does this not fall out of the grammar productions for the relevant constructs?

@sdkrystian
Copy link
Contributor Author

@timsong-cpp This is indeed redundant (as older wording tends to be)

Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"declarators" is misleading

source/expressions.tex Outdated Show resolved Hide resolved
source/expressions.tex Outdated Show resolved Hide resolved
@jensmaurer jensmaurer added this to the C++20 milestone Sep 17, 2020
@zygoloid zygoloid merged commit cd729c4 into cplusplus:master Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants