[string.conversions] Replaced comparisons of a pointer against 0 with comparision against nullptr #3941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nullptr, for consistency with other parts of the library
|
Please add the [stable.name] for the affected subclause(s) to the commit summary. |
gamecentric
changed the title
|
Sorry. Done it. |
jensmaurer
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While technically correct, comparing pointers against nullptr is usually preferred to comparing them against the null pointer costant 0. Moreover, it seems more consistent to compare against nullptr, since the default value of the pointer idx is actually declared as nullptr in the synopsis.