[class.abstract] Clean up redundant wording #3960
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
requested changes
Apr 29, 2020
| In general, an abstract class type can only be used | ||
| \begin{itemize} | ||
| \item | ||
| as the referred to type in a reference, |
There was a problem hiding this comment.
No. That's awkward and needs at least a hyphen, but even better, needs a rephrasing. Maybe "referenced type" and "pointee type" or so?
| \item | ||
| in an explicit type conversion | ||
| to the above types~(\ref{expr.static.cast}, \ref{expr.reinterpret.cast}, | ||
| \ref{expr.const.cast}, \ref{expr.dynamic.cast}), or |
There was a problem hiding this comment.
That's an odd point to make, given that you already highlighted that you can form pointers and references to abstract class types.
zygoloid
added
the
changes requested
wg21bot
added
the
needs rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[class.abstract] p2 sentence 3 is entirely redundant by [class.abstract] p4, [class.abstract] sentence 5 is redundant by [basic.def.odr] p3.1, the normative specification for [class.abstract] p6 makes more sense in [class.cdtor] p4, [class.abstract] p2 note 2 and [class.abstract] p3 can be merged into a single note, and the definition of abstract class in [class.abstract] p4 doesn't need to care about final overriders, since members of a base class that aren't redeclared are members of the derived class.
The definition of pure virtual function should probably use
\defnadj, but please let me know what makes the most sense :)