[temp.local] Remove space between angle brackets in example #3961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
reviewed
Apr 29, 2020
| @@ -4747,7 +4747,7 @@ | |||
| }; | |||
|
|
|||
| template<class T, template<class> class U = T::template Base> struct Third { }; | |||
| Third<Derived<int> > t; // OK: default argument uses injected-class-name as a template | |||
| Third<Derived<int>> t; // OK: default argument uses injected-class-name as a template | |||
There was a problem hiding this comment.
I think we don't want to change this under the "core sections show a variety of syntactically valid styles" doctrine. (There are also a few more places in the core language section where > > is used, so this is also a questionable improvement in overall consistency.)
There was a problem hiding this comment.
Ah, the one place I didn't look when checking for more instances was... [temp]. I can still wait for @zygoloid to look this over if we want, but I agree with you that we shouldn't make the change
|
Author agreed not to apply the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't do this very much, if at all.