[conv.integral, conv.double] Fix promotion conversions #3963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
requested changes
Apr 29, 2020
|
@jensmaurer Should be good now. |
sdkrystian
changed the title
jensmaurer
reviewed
Apr 29, 2020
jensmaurer
reviewed
Apr 29, 2020
jensmaurer
reviewed
Apr 29, 2020
jensmaurer
reviewed
Apr 29, 2020
sdkrystian
force-pushed
the
patch-73
branch
3 times, most recently
from
2953ccd
to
1782eb7
Compare
jensmaurer
approved these changes
May 29, 2020
|
This appears to be a normative change: it affects which conversions are permitted in converted constant expressions. It might be a good change, and it's certainly clearer to have each conversion have only one kind, but this should probably be handled by a core issue. |
wg21bot
added
the
needs rebase
|
@sdkrystian Could you please rebase? |
|
@tkoeppe Yup, will do it Monday |
opensdh
reviewed
Nov 12, 2023
|
@tkoeppe Rebased |
|
Thanks! We'll have to look at it in Core, but we wanted a clean diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boolto [conv.bool], we can just exclude them from the set of integral conversions (no normative effects as it delegates).floattodouble); we need not say "conversions".